Echo2extras: All The (user Contrib) Patches

LATEST VERSION 20070603 IS >>HERE<<

Hello all

I want to open a topic where to collect ALL the extras patches, in the hope to track them more easily.

I've collected the patches I've found in the forum, added some of mine and bundled them into one diff file.

The solved issues are:

  • TabPane
    • setTabHeight: the method has been enabled
    • setTabTitleInsets (new method): resizing the tab, you could need to make the label nearer the tab border
    • setTab(Ina|A)ctiveFont: enabled methods [1]
    • ACTIVE_TAB_INDEX_CHANGED_PROPERTY: now it fires the property change each time you click on a tab. [2]
  • AccordionPane
    • ACTIVE_TAB_INDEX_CHANGED_PROPERTY: now it fires the property change each time you click on a tab.
  • CalendarSelect
    • some .properties corrected
  • MenuBarPane
    • setFont: method enabled
Apply it to your local SVN repository and rebuild echo2extras

At the office, we've automated this procedure by creating a build.xml file that gets the sources, applies the available patches and rebuild all the rebuildable. I'll try get it to the public asap.

HTH

Credits:
[1] [url=http://forum.nextapp.com/forum]http://forum.nextapp.com/forum]
[2] [url=http://forum.nextapp.com/forum]http://forum.nextapp.com/forum]

PLUS:
This a bit of topic, but: Should we use bugzilla or something? I think it will be much easier to track bug reports and apply patches. It could even lead to a wider participation to echo development. Unfortunately, I can't install neither bugzilla nor trac on my website :(. Looking forward for your opinion

ATTACHMENT NO MORE VALID: CHECK MY LATEST POST FOR THE UPDATED VERSION

[/][/][/][/][/]

There's a wiki page where you can add links to bugs/fixes.
See Echo2Bugs

tima wrote:

There's a wiki page where you can add links to bugs/fixes.
See Echo2Bugs

yep, I'm just thinking I shouldn't use a wiki when there are dedicated tools such as bugzilla where
  • I can create reports of (open/closed) bugs in a click
  • It is difficult to go off topic (much more difficult than a forum)
  • I can attach and version files: at now you do that in the forum, so from the wiki page you need to go the forum, read the thread, find the right patch file (if more than one exists)
  • Closing bugs, you have feedback about they being applied upstream or not
I just think a wiki is not the right tool, nor a forum. e.g: take a look at this

[/]
mjablonski's picture

federico wrote:

I just think a wiki is not the right tool, nor a forum.

Hi,

the Wiki was meant as simple workaround for "referencing" bug reports in the forum, which get (too) easily lost other ways. You're right, it's no replacement for a real bug-tracker (nor is the forum).

I'm fully agree that we need some more community-tools for the Echo2-Project if the project is going to stay.

I don't know what's the reason for Tod/Nextapp being silent in the forums for months, but maybe we come close to the point where we should think about building an "independent" open-source-community around Echo2.

Cheers, Maik

mjablonski wrote:

I don't know what's the reason for Tod/Nextapp being silent in the forums for months, but maybe we come close to the point where we should think about building an "independent" open-source-community around Echo2.

I agree, absolutely. Tod may be busy as everyone else and I won't ever blame him for that, just because I can be busy too.
That's why I agree in contributing to the community with some other tool and way.

My web host does not support java and I got troubles setting up bugzilla due to cgi permissions. So I was taking a look at Mantis and BUGS.
BUGS is not easy to consult by anonymous users (guest account, IIRC) so Mantis seems the choice

Opinions?

Update!

MenuBarPane

  • setFont: method enabled

[/]

Hello all

I've just updated the patch against the latest svn version of echo2extras. It's attached.

A couple of adds and mods have been done of the upstream release. This release aims just to make the patch work with the latest svn version.

So check the details in the first post

eskatos's picture

Hi federico,

Thanks for this very usefull patch.
Isn't there any patche for TabPane.setTabWidth, it apperas that this method is not active yet.

I fully agree with the idea of a opensource user driven contribution site, with a bugstracker, a svn etc..

Regards

Paul

Yep, there isn't the implementation. I will add it asap.

Finally I got time for that

added support for {g,s}etTabWidth :)
what happens is that if you set the width, the tab will use it and no way they will adapt it to the tab title. Otherwise, the length of the title will make the tab adapt its width
that is to say: width SET = dynamic tab width, width NOT SET = fixed tab width

check the attached updated patch

federico wrote:

Finally I got time for that

added support for {g,s}etTabWidth :)
what happens is that if you set the width, the tab will use it and no way they will adapt it to the tab title. Otherwise, the length of the title will make the tab adapt its width
that is to say: width SET = dynamic tab width, width NOT SET = fixed tab width

check the attached updated patch

How can I apply the Federico's patches??

on unix like systems (even on cygwin I think) go to the folder right below the "src" folder and type
patch -p0 < echo.extras.diff.txt

obviously you first need to checkout the extras from the repository
check out http://wiki.nextapp.com/echowiki/Echo2Extras

federico wrote:

on unix like systems (even on cygwin I think) go to the folder right below the "src" folder and type
patch -p0 < echo.extras.diff.txt

obviously you first need to checkout the extras from the repository
check out http://wiki.nextapp.com/echowiki/Echo2Extras

Thanks for your replay.
Unfortunately the jar file I generated doesn't seem to work :(

How can I do??
I've cheked out Echo2Extras and applied the patches.
I've compiled the App and WebContainer extras and replaced them into my project.
So I have Echo2_Extras_App_patched and Echo2_Extras_WebContainer_patched instead of Echo2_Extras_App and Echo2_Extras_WebContainer

Luca wrote:

Thanks for your replay.
Unfortunately the jar file I generated doesn't seem to work :(

and what's the error?

federico wrote:

and what's the error?

A general application error...
It seems there is some problem with libs
Maybe there is some error during the genereation of jar file...
I don't know...

federico wrote:

and what's the error?

I have replaced echo2_Extras_App and webcontainer whit the jars i generated from the source I get from svn.
My application work fine with the old jar but with the new files i have:
"An application error has occurred. Your session has been restarted".
Any idea???

Luca wrote:

"An application error has occurred. Your session has been restarted".

again: what error? I need a stack trace in order to help you

federico wrote:

again: what error? I need a stack trace in order to help you

OK!! I find it....
thw stack is:

java.lang.UnsupportedClassVersionError: nextapp/echo2/extras/app/MenuBarPane (Unsupported major.minor version 49.0)
at java.lang.ClassLoader.defineClass0(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:537)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:123)
at org.apache.catalina.loader.WebappClassLoader.findClassInternal(WebappClassLoader.java:1634)
at org.apache.catalina.loader.WebappClassLoader.findClass(WebappClassLoader.java:860)
at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1307)
at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1189)
at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:302)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:219)
at nextapp.echo2.app.componentxml.StyleSheetLoader.load(StyleSheetLoader.java:131)
at nextapp.echo2.app.componentxml.StyleSheetLoader.load(StyleSheetLoader.java:78)

Thanks for your interesting

Update:

  • AccordionPane: added {get/set}TabFont methods
Thanks to user Luca for contributing

[/]

Is there some new jar somewhere with all these patches you and the other users contributed? It wouldn't be very practical to pick up each diff and compile each one...

Thanks in advance!

Please, I'm not able to reach the svn repository. Can someone post the jar with these patches applied?

Thanks a bunch! :D

C'mon... can't you publish the jar?

Grolubao wrote:

C'mon... can't you publish the jar?

I think it would be better if you asked Tod to apply these fixes to the Echo2 extra's library. Of course, with Tod working on Echo3, I don't like your chances.

hi. is there any release for TabPane.setFont methods?

Fly wrote:

hi. is there any release for TabPane.setFont methods?

I don't know if it's of any help to you but the fork project fixed this bug in both the TabPane and the AccordianPane:
http://karora.org/JIRA/browse/COO-13
http://karora.org/JIRA/browse/COO-14

thanks for reply, but it will be better to have release of new jars for that.

Fly wrote:

thanks for reply, but it will be better to have release of new jars for that.

as you can understand by this post
http://forum.nextapp.com/forum]
Nextapp has ignored this patchset since the beginning. Some time ago, they've made some updates and I also had to adapt my patchset to their latest svn version.

They just skipped it, so don't expect to have it applied on the official jars

Check this out for info on applying it by yourself
[url=http://echocore.svn.sourceforge.net/viewvc/echocore/trunk/patched/]http://echocore.svn.sourceforge.net/viewvc.../trunk/patched/

I've tried to checkout the following repository svn://svn.nextapp.com/echo2extras

but without success... (always gives me timeouts)
Can someone upload here the extras jar with the patches already applied?

Thanks a bunch